Optimize getting of ShortName of System.Type #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- System.Type.Name instead of .GetShortName() extension in places where there it is obvious that short name is equal to Type.Name (type is not nested, it is class, and it is not generic), only for types we have created and control. - avoid getting type name when logging is skipped. RuntimeType has names caching mechanisms so we can rely on it instead of having ours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.Type.Nameinstead of.GetShortName()extension in places where there it is obvious that short name is equal toType.Name(type is not nested, it is class, and it is not generic), only for types we have created and control.RuntimeTypehas names caching mechanisms so we can rely on it instead of having ours.